Merged
Conversation
The EinExprs weakdep (via ITensorNetworksEinExprsExt) constrains DataStructures to 0.18, so the 0.19 entry is aspirational — users who load the EinExprs extension can never reach it. Widen back if/when EinExprs loosens its DataStructures compat, or remove the entry entirely once EinExprs support is dropped. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #328 +/- ##
==========================================
- Coverage 71.45% 71.43% -0.03%
==========================================
Files 81 81
Lines 4029 4029
==========================================
- Hits 2879 2878 -1
- Misses 1150 1151 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mtfishman
added a commit
that referenced
this pull request
Apr 26, 2026
`DataStructures` was narrowed to `"0.18"` in #328 because the `EinExprs` weakdep pinned it that way. The `EinExprs` dependency was removed in #327, but the narrowed `DataStructures` compat was never reverted (and `DataStructures` itself is no longer `using`'d anywhere in `src/`, `ext/`, or `test/`). Drop the entry entirely from `[deps]` and `[compat]`. This also unblocks `OrdinaryDiffEqTsit5 = "1.1, 2"` resolution: the v2 chain pulls in `OrdinaryDiffEqCore` 4, which requires `DataStructures` 1.x-3.x and was previously incompatible with the 0.18 pin. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
mtfishman
added a commit
that referenced
this pull request
Apr 26, 2026
`DataStructures` was narrowed to `"0.18"` in #328 because the `EinExprs` weakdep pinned it that way. The `EinExprs` dependency was removed in #327, but the narrowed `DataStructures` compat was never reverted (and `DataStructures` itself is no longer `using`'d anywhere in `src/`, `ext/`, or `test/`). Drop the entry entirely from `[deps]` and `[compat]`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
EinExprsweakdep (viaITensorNetworksEinExprsExt) pinsDataStructuresto0.18. The0.19entry in the root compat is never reachable when the extension is loaded, so it is aspirational.Under the compat-bounds check's breaking-bucket rule (ITensorActions#79), this spans two buckets (0.18 and 0.19) and fails the check. Narrowing to
"0.18"collapses to a single bucket.Widen back if
EinExprsloosens itsDataStructurescompat, or remove the entry entirely onceEinExprssupport is dropped.